Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect chroma location handling with vo=gpu #15288

Closed
6 tasks done
emotion3459 opened this issue Nov 10, 2024 · 1 comment · Fixed by #15293
Closed
6 tasks done

Incorrect chroma location handling with vo=gpu #15288

emotion3459 opened this issue Nov 10, 2024 · 1 comment · Fixed by #15293
Labels

Comments

@emotion3459
Copy link

mpv Information

mpv v0.39.0-300-g42ff6f92 Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on Nov  3 2024 00:06:03
libplacebo version: v7.349.0 (v7.349.0-19-g118d810-dirty)
FFmpeg version: N-117698-gc325f9c61
FFmpeg library versions:
   libavcodec      61.23.100
   libavdevice     61.4.100
   libavfilter     10.6.101
   libavformat     61.9.100
   libavutil       59.46.100
   libswresample   5.4.100
   libswscale      8.9.101

Other Information

- Windows version: Windows 11
- GPU model, driver and version: GTX 1080Ti, Driver 561.09
- Source of mpv: scoop

Reproduction Steps

Use vo=gpu and open a subsampled file with top-left chroma location.

Expected Behavior

Behavior should match gpu-next.

Actual Behavior

Chroma is erroneously shifted downwards. Comparison

Log File

output.txt

Sample Files

Sample

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.
@kasper93
Copy link
Contributor

Chroma offset is flipped vertically in vo_gpu. Will fix later, when I get some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants