Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to Hell - Changing FPS #15343

Open
vslmc opened this issue Nov 20, 2024 · 2 comments
Open

Road to Hell - Changing FPS #15343

vslmc opened this issue Nov 20, 2024 · 2 comments

Comments

@vslmc
Copy link

vslmc commented Nov 20, 2024

mpv Information

No response

Important Information

All versions of MPV

Reproduction Steps

Simply changing the FPS of media (and adding pitch) manually is more complex than it needs to be.

Problem:
Change 23.976 to 24 and normalize audio

Solution:

[23.976 to 24]
profile-cond=container-fps=23.976
speed=1.001001
pitch=1.001001
audio-pitch-correction=no
af-add=rubberband=pitch-scale=0.999,engine=finer
sub-speed=24/23.976 (this value will work with speed/pitch too ?)
sub-fps=24

Proposed solution:
If mpv can handle conditions, how about the following:

fps-cond = 23.976 = 24
audio-pitch-correction = hd
sub-??? = video-out-fps

Additionally it would be nice to hold one frame longer instead of repeating it. hold-cond = 24 = 2 for example would output 24 frames in 2 seconds instead of bobbing the output to 48 frames (reduces CPU/GPU usage)

Also I want to mention that the manual is very confusing on this topic, see image attached:

IMG_20241120_221224

Expected Behavior

Simple and straightforward

Actual Behavior

Not simple and straightforward

@Hrxn
Copy link
Contributor

Hrxn commented Nov 21, 2024

I assume at 1.2x normal speed just means at 1.2x times the normal speed, i.e. sped up by factor 1.2 😆

@vslmc
Copy link
Author

vslmc commented Nov 21, 2024

What two words can change 🤯 Actually I read that sentence 10 times and questioned my sanity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants