Should audio/sub tracks (-aid/-sid options) start counting from 0 or 1?

[ghost]

Currently, these start counting from 0, but the OSC (on screen controller, see issue #172) starts from 1, meaning it will show different track numbers than native mpv functionality (including the -aid/-sid options and the terminal output).

For consistency, it would be better if all of mpv follows a single convention.

So which should it be?

[pigoz]

Well 0 numbering is not very pretty on a GUI (but it's not the end of the world). If you have 3 tracks the 3rd one will be 2/2? Anyway, consistency is the most important thing.

[ChrisK2]

If you have 3 tracks the 3rd one will be 2/2?

It would be "2/3" which is not pretty at all, and will not make much sense to users unfamiliar with the inner workings of mpv.

IF we switch to 1-based, we can go with:
-1: whatever is tagged as default
0: none/disabled
1: first track

[rossy]

I don't think 1 based IDs are a necessarily a bad thing for the command line options. Even without the OSC, it seems natural to select the first and second audio tracks with mpv --aid=1 and mpv --aid=2.

[pigoz]

It would be "2/3" which is not pretty at all, and will not make much sense to users unfamiliar with the inner workings of mpv.

2/3 doesn't make any sense. If we decide for 0 based indexing it should show 2/2 imho.

[przemoc]

2/2 is bad for obvious reasons. Why not something like: 2/(0-2) or even better #2 (#0-2)?

[ChrisK2]

2/3 doesn't make any sense. If we decide for 0 based indexing it should show 2/2 imho.

Indexing != Counting. Even with 0-based indexing, your counting is always 1-based. You need to be able to express "none" after all.

Why not something like: 2/(0-2) or even better #2 (#0-2)?

Too long and ugly.

[ghost]

So it seems nobody really cares about this and only ChrisK is insisting on changing it to 1... then, so be it. Changed with c8a7140.

[wyatt8740]

Is there any way to reverse this???

It's driving me absolutely insane and breaking my scripts that I'm trying to port from mplayer.