-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can no longer deinterlace certain files with d key #2539
Comments
The yadif inserted by the d key only deinterlaces frames tagged interlaced. The non-working files are probably broken. You can try adding --field-dominance=top or bottom (depending on which they are) - the idet filter as inserted with TOOLS/idet.sh or TOOLS/lua/autodeint.lua should be able to figure it out. Unfortunately, the vf-defaults trick no longer works for the "d" key because of the way that the extra options are added. This is a known issue. |
The vf-defaults thing could be easily fixed with a hack. But I'm also pondering a --deinterlace=force flag, which would override the current behavior. (I'm also wondering whether the "normal" --deinterlace mode could be made default.)s |
I'd also like some way to force deinterlacing, ideally toggable during playback. |
Yes, my non-working files are broken. Some of them are interlaced material that were captured as progressive, some are progressive that are flagged interlaced, all have different field dominance... At first I figured out that I could get the old behavior back of forcing deinterlace by binding: I decided I prefer the "field" setting though. But then I needed a second key to set the field-dominance for the broken files. I guess you'd have the same problem with a So I set I ended up mapping the d key to cycle through forcing deinterlace with bottom, top, or disabled, or back to auto: That seems to work well. Most of the time I don't have to do anything, and all broken files can be handled with one key. I did try idet.sh, which didn't seem to do anything, and autodeint.lua, which generally works but isn't always consistent. For example I found it often didn't work right during the opening titles. Still it's good to have as an option. I also set |
I can't get the proposed solution of d cycle-values deinterlace yes yes no yes; cycle-values field-dominance bottom top auto auto; show-text "deinterlace: ${deinterlace} ${field-dominance}" to work Is there any progress on forcing deinterlace toggleable with the 'd' key? |
@mystica555 , there wasn't any progress, since this bug was closed as fixed in 2015. It remained fixed up until release 0.27.0, Sept. 2017. The above method still works in release 0.26.0, on your example youtube file. Hardware decoding must be turned off. The autodeint.lua script also works, if hardware decoding is off. As of release 0.27.0, I can't get either of those methods to work. The release notes for 0.27.0 include:
I assume that's why. I tried removing the "field-dominance" part of the command, but it didn't help. |
Using release 0.10 and later, using the d key to turn on deinterlacing doesn't work for some files that worked in previous versions of mpv.
I added
vf-defaults=yadif=field:no
to mpv.config. But it still doesn't work. If I turn it on withvf=yadif=field:no
it works, but then I can't turn it off with the d key.It seems that putting frame/field in
vf-defaults
has an effect, but yes/no for interlaced-only does not. [edit: I was mistaken, frame/field has no effect either.]Tested on OS X 10.10.
The text was updated successfully, but these errors were encountered: