Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference frames to D3D11 hardware decoding so that adaptive and motion compensation deinterlace works #9407

Open
Aktanusa opened this issue Nov 7, 2021 · 2 comments

Comments

@Aktanusa
Copy link

Aktanusa commented Nov 7, 2021

Before requesting a new feature make sure it hasn't been requested yet.
meta:feature-request

Expected behavior of the wanted feature

Currently, it seems the D3D11 deinterlacing is set to bob. According to this MS link, this is due to not having enough reference frames. When comparing vf_d3d11vpp.c to a sample of other D3D11 deinterlacing code like MPC Video Renderer here and VLC here, it seems to be missing usage of PastFrames and FutureFrames, which I believe they are used for reference frames. Going by MPC-HC, I think 4 frames are needed at least.

Alternative behavior of the wanted feature

Log file

https://pastebin.com/ZemA8PZv

Even if you think it's not necessary at first, it might help us later to find
possible issues. Make a log file made with -v -v or --log-file=output.txt, paste
it to https://0x0.st/ or attach it to the github issue, and replace this text
with a link to it.

@Aktanusa
Copy link
Author

I'm not sure what you are asking. VLC has varies deinterlace modes, and the naming depends on using DXVA or D3D11. As far as I can tell, it does support 2x FPS mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@Aktanusa and others