Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

po file content should be also checked in the tests #67

Closed
mquinson opened this issue Nov 21, 2017 · 0 comments
Closed

po file content should be also checked in the tests #67

mquinson opened this issue Nov 21, 2017 · 0 comments

Comments

@mquinson
Copy link
Owner

in #62, we came to the conclusion that the po files that are produced during the tests are not part of the test. I kinda think that this is bad, and that we should also check that the po file looks as expected after the test.

But comparing it is not straightforward: we probably want to ignore the differences in the header and the ones about the location in the file. So I'm not completely sure of what we want to see here, and I'm seeking feedback about what you guys think of it.

Thanks, Mt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant