Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set output warning when running this action #112

Closed
kotikoB opened this issue Oct 22, 2022 · 7 comments · Fixed by #113
Closed

Set output warning when running this action #112

kotikoB opened this issue Oct 22, 2022 · 7 comments · Fixed by #113
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@kotikoB
Copy link

kotikoB commented Oct 22, 2022

Screenshot 2022-10-22 at 09 56 49

@mr-smithers-excellent mr-smithers-excellent self-assigned this Oct 23, 2022
@mr-smithers-excellent
Copy link
Owner

Hi @kotikoB. Thanks for bringing this to my attention. I'm not yet sure if these are commands I'm using directly or if they are pulled from dependencies. In any event, I'll get a solution for this merged before the deprecation date of May 31, 2023. Here's more info:

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@mr-smithers-excellent mr-smithers-excellent added the dependencies Pull requests that update a dependency file label Oct 23, 2022
@erzz
Copy link
Contributor

erzz commented Oct 25, 2022

+1 for the issue as I came here to write the same thing

To be honest, looking at your source, its seems a problem with the core github package as far as I can tell as you aren't doing anything more than core.setOutput(...); 🤷🏻

But I see they have released a new version https://github.com/actions/toolkit/releases/tag/%40actions%2Fcore%401.1.0 though actual changelogs dont indicate a change related to it yet

There is an open issue with a possible workaround though actions/toolkit#1218

@mr-smithers-excellent
Copy link
Owner

Super helpful! I did some digging myself and couldn't see anything obvious aside from upgrading @actions/core.

It seems odd they would publish deprecation warnings without an immediate solution in their own libraries. I'll watch that issue and see if anybody from the GH team chimes in.

@kotikoB
Copy link
Author

kotikoB commented Oct 27, 2022

Thank guys, waiting to try the fix once the PR is merged.

@mr-smithers-excellent
Copy link
Owner

@erzz - now that I look at the nightly e2e tests, it looks like this actually is resolved. Can you give this a try on your end using the @master branch?

@erzz
Copy link
Contributor

erzz commented Oct 31, 2022

Morning @mr-smithers-excellent

Indeed the warnings are gone using @master! 🎉

One remains about node12 actions, but the set-outputs ones are no more

image

@mr-smithers-excellent
Copy link
Owner

Thanks, @erzz! I'll close ticket issue then and get that other warnings cleared out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants