Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo issue in introduction-to-numpy.ipynb #101

Open
hsenbassam opened this issue Aug 18, 2024 · 4 comments
Open

Typo issue in introduction-to-numpy.ipynb #101

hsenbassam opened this issue Aug 18, 2024 · 4 comments

Comments

@hsenbassam
Copy link

In ### What unique values are in the array a3?
"unique" is wrongly written in "how to find the unique values in a numpy array"

@kRiShNa-429407
Copy link

kRiShNa-429407 commented Aug 18, 2024

Please mention video number and time stamp or screenshot for better response

@hsenbassam
Copy link
Author

Please mention video number and time stamp or screenshot for better response

In https://github.com/mrdbourke/zero-to-mastery-ml/blob/master/section-2-data-science-and-ml-tools/introduction-to-numpy.ipynb we have a typo in the section of What unique values are in the array a3?
Here is a screenshot for better visibility:
Screen Shot 2024-08-18 at 3 22 48 PM

@kRiShNa-429407
Copy link

kRiShNa-429407 commented Aug 18, 2024

Yes you're right!

a3 numpy array has all values different or unique , so when you will apply '.unique()' to the array it will return the same array because all values are unique.

I think Daniel is pointing to other array but he typed wrong as a3.

To find unique values in a numpy array check
https://numpy.org/doc/stable/reference/generated/numpy.unique.html

@hsenbassam
Copy link
Author

Yes you're right!

a3 numpy array has all values different or unique , so when you will apply '.unique()' to the array it will return the same array because all values are unique.

I think Daniel is pointing to other array but he typed wrong as a3.

To find unique values in a numpy array check https://numpy.org/doc/stable/reference/generated/numpy.unique.html

Thank you ! it is more about typo what I meant, should be "unique" and not "unqiue", not a big deal and I just tried to contribute, the notebook is well written

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants