Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logarithmicDepthBuffer causes shader compile errors on Firefox for Android #10664

Closed
4 of 11 tasks
fraguada opened this issue Jan 26, 2017 · 3 comments
Closed
4 of 11 tasks

Comments

@fraguada
Copy link
Contributor

Description of the problem

Hello! Today I detected a problem on Firefox for Android 50.1.0 and Firefox for Android 51 Beta. If I switch on renderer.capabilities.logarithmicDepthBuffer= true; the scene fails to load due to a shader compilation error. Here is a gist with the console messages from a remote debugging session.

Here is a jsfiddle which fails on Firefox for Android, but Chrome for Android 55.0.2883.91 seems to work fine.

Here is a jsfiddle which works on Firefox for Android. All that is different is renderer.capabilities.logarithmicDepthBuffer= false;.

This was tested on a BQ androidone and Huawei P9.

Three.js version
  • Dev
  • r79
  • r84
Browser
  • [] All of them
  • Chrome
  • Firefox for Android 50.1.0 and 51 beta
  • Internet Explorer
OS
  • All of them
  • Windows
  • Linux
  • Android
  • IOS
Hardware Requirements (graphics card, VR Device, ...)
@mrdoob
Copy link
Owner

mrdoob commented Jan 27, 2017

Ohm... I don't think renderer.capabilities.logarithmicDepthBuffer shouldn't be changed at runtime. You should pass the flag in the constructor instead:

var renderer = new THREE.WebGLRenderer( { logarithmicDepthBuffer: true } );

Do these updates jsfiddles still have the issue?

https://jsfiddle.net/6hLgnqke/2/
https://jsfiddle.net/gtduv3ef/3/

@fraguada
Copy link
Contributor Author

fraguada commented Jan 28, 2017

Hello,
The first link https://jsfiddle.net/6hLgnqke/2/ still had the issue, since logarithmicDepthBuffer = true. I haven't had a chance to check the console output, but did a remote debugging session which yielded very similar results as the previous dump. The result on firefox for android is the same, the scene does not show up.

Ohm... I don't think renderer.capabilities.logarithmicDepthBuffer shouldn't be changed at runtime.

Fair enough. I was attempting a workaround for this issue in my particular case. I can modify my code to define the render after I know enough information to decide if the renderer should use logarithmic depth buffer or not. All that being said, it does not change the fact that logarithmicDepthBuffer: true causes shader compile errors on Firefox for Android in both cases described in this issue.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 10, 2018

I'm unable to reproduce with latest Firefox 61 on Android 8.1. In any event, bugs like this should be directly reported to https://bugzilla.mozilla.org/

@Mugen87 Mugen87 closed this as completed Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants