Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Mesh clone method support a "recursive" argument #16315

Closed
yennyF opened this issue Apr 23, 2019 · 3 comments
Closed

Suggestion: Mesh clone method support a "recursive" argument #16315

yennyF opened this issue Apr 23, 2019 · 3 comments

Comments

@yennyF
Copy link

yennyF commented Apr 23, 2019

Grettings!
if mesh inherits the method add children (from Object3D), its clone method should support taking a "recursive" argument or at least make the Mesh class consistent.

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 23, 2019

@gkjohnson
Copy link
Collaborator

gkjohnson commented Apr 23, 2019

This should be a pretty easy fix (though breaking if the current behavior is relied on anywhere Edit: the change should actually be backwards compatible). The real question is whether or not there's a reason Meshes are assumed to not have children. I don't think I have strong opinions either way.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 16, 2021

I think this issue can be closed. Starting with #19471 classes like Mesh do not have overwritten clone() methods anymore. They all use the implementation of Object3D.

@Mugen87 Mugen87 closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants