-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRACOLoader: Add parse() method #17593
Comments
What options does it need? |
Currently For users with Draco-compressed |
I think I would follow ImageBitmapLoader pattern. var loader = new THREE.DracoLoader();
loader.setOptions( {} );
loader.parse( 'file.drc', onParse, onError ); |
Disadvantage here is that We could make sure the options are copied and stored for the task duration when parse is called, to support this pattern... loader
.setOptions( { ... } )
.parse( buffer1, onLoad, onError )
.setOptions( { ... } )
.parse( buffer2, onLoad, onError ); ... but I don't know if that's better or not. 🤔 |
This comment has been minimized.
This comment has been minimized.
After #25390 and #27306, If there is no urgent demand, I vote to close the issue. |
The deprecated
decodeDracoFile
method should be removed and replaced with aparse
method similar to other loaders. CurrentlydecodeDracoFile
does not propagate errors, and should do so. So probably a signature like:The text was updated successfully, but these errors were encountered: