Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing remaining lgtm alerts. #19057

Closed
3 of 15 tasks
Mugen87 opened this issue Apr 6, 2020 · 5 comments
Closed
3 of 15 tasks

Fixing remaining lgtm alerts. #19057

Mugen87 opened this issue Apr 6, 2020 · 5 comments

Comments

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 6, 2020 •
edited
Loading

Description of the problem

I'd like to use this issue to track the remaining lgtm alerts. After a series or PRs, there are only three left.

Three.js version
  • Dev
  • r115
  • ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Windows
  • macOS
  • Linux
  • Android
  • iOS
Hardware Requirements (graphics card, VR Device, ...)
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 6, 2020 •
edited
Loading

Both alerts are actually not easy to fix. Let's see if the original developer of NRRDLoader can help with the latter one.

The first one in doc_comment.js is strange. I don't get the usage of the madeUp variable and the respective assignments.

@mrdoob
Copy link
Owner

mrdoob commented Apr 7, 2020

Seems like tern.js no longer has that issue:
https://lgtm.com/projects/g/ternjs/tern/

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 7, 2020

Um, they actually deleted the mentioned line: ternjs/tern@3f8a2bc

Let's apply this hotfix 🤓

This was referenced Apr 7, 2020
Merged
Merged
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 7, 2020

image
Yay! 🎉 🎉 🎉

@Mugen87 Mugen87 closed this as completed Apr 7, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 7, 2020

👏👏👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrdoob @Mugen87