-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighter pakage.json dependencies (remove puppeteer by default) #19332
Comments
An option would be to put a |
The solution was simple. Need to rethink this, +150mb is annoying. |
Ty. |
Merged
Solved, sanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the problem
Some of the developers cloning three.js repo without the intention to contribute. This is happening because they want to make tree-shake library or modify core for your own purposes in projects.
The idea is to introduce to two additional commands and suggest in console to install puppeteer only those developer who want to take screenshots in PRs.
But by doing so we modifying
package.json
afternpm run make-install
and facing another problem: we need to say to contributors not to addpackage.json
orpackage-lock.json
, which is relatively easy but little bit uncomfortable. I wonder if exist any safe way to keeppackage.json
the same after install.This idea is consistent with #19321 #19326
The text was updated successfully, but these errors were encountered: