Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KHR_materials_sheen to GLTFLoader #22710

Closed
oddnugget opened this issue Oct 20, 2021 · 1 comment
Closed

Add KHR_materials_sheen to GLTFLoader #22710

oddnugget opened this issue Oct 20, 2021 · 1 comment
Labels
Enhancement

Comments

@oddnugget
Copy link

Is your feature request related to a problem? Please describe.
Currently the GLTFLoader supports all KHR_material extensions except sheen.

Describe the solution you'd like

It would be awesome if the GLTFLoader would be patched to include KHR_materials_sheen. After some research it seems that there is a sheen property on MeshPhysicalMaterial, but it doesn't map one to one with KHR spec.

Describe alternatives you've considered

Additional context
@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 20, 2021 •
edited
Loading

Support for the extension is added with #22677 and #22687.

However, the engine's current sheen BRDF is not yet glTF conform. This is already tracked here: #22359

@mrdoob mrdoob closed this as completed Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrdoob @Mugen87 @oddnugget