UniformUtils does not set needsUpdate to true for Texture uniforms

[FarazzShaikh]

Describe the bug

As explained by the docs, when a texture is cloned, the needsUpdate flag must be set to true. Else, the texture appears black.

UnifromUtils.clone and by extension, UnifromUtils.merge, do not set this flag even though they clone Texture and other uniform types.

three.js/src/renderers/shaders/UniformsUtils.js

Line 22 in f51dd8a

dst[ u ][ p ] = property.clone();

Easy fix, will PR in the morning if this is indeed a bug and not intended.

To Reproduce

1. Create a unifrom object with a texture property
2. Clone the unifrom
3. Use cloned unifrom, the texture will appear black.

Code

// Works
material.uniforms.u_map.value = texture;

// Doesnt work (texture is black)
const clonedUifroms = UniformsUtils.clone(material.uniforms);
material.uniforms.u_map.value = clonedUifroms.u_map.value;

// To fix
material.uniforms.u_map.value.needsUpdate = true;

Live example

CodeSandbox

Expected behavior

The "To fix" line shouldn't be required, UniformsUtils.clone should set needsUpdate automatically.

Platform:

• Device: [Desktop]
• OS: [Windows]
• Browser: [Chrome]
• Three.js version: [0.138.0]

[WestLangley]

See #22718 (comment)

[FarazzShaikh]

Fair enough, cheers!