Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheen from IBL isn't being affected by AO #26939

Closed
bhouston opened this issue Oct 10, 2023 · 1 comment · Fixed by #26940
Closed

Sheen from IBL isn't being affected by AO #26939

bhouston opened this issue Oct 10, 2023 · 1 comment · Fixed by #26940
Labels

Comments

@bhouston
Copy link
Contributor

bhouston commented Oct 10, 2023

Description

The sheen effect I am noticing isn't being darkened by AO in the case where the Sheen is resulting from the IBL. When sheen is the result of the IBL it is considered to be indirect lighting and as such it should be decreased in areas where the ambient occluding factor is high.

I can not see this being done anywhere in the shader code and I have examples where it is cause very problematic lighting issues.

Reproduction steps

Create an AO 1 area, then light it via indirect. It will be black. Add sheen and it will become white.

Code

I don't have any code examples.

Live example

I do not have one yet.

Screenshots

Such as this internal crease of a sofa, when I increase sheen the AO'ed area becomes white - that is very wrong:

Screenshot 2023-10-10 at 5 01 29 PM
Screenshot 2023-10-10 at 5 01 25 PM

Version

r152

Device

Desktop

Browser

Chrome

OS

MacOS

@bhouston
Copy link
Contributor Author

I will submit a fix for this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants