Editor: Runtime error in history.

[Mugen87]

Description

When using persistent history, a runtime error is thrown when deleting an object and refreshing the page.

RemoveObjectCommand.js:17 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'name')
at new RemoveObjectCommand (RemoveObjectCommand.js:17:79)
at History.fromJSON (History.js:204:16)
at Editor.fromJSON (Editor.js:674:16)
at async index.html:115:7

Reproduction steps

1. Enable persistent history in the settings tab.
2. Add a box.
3. Delete it.
4. Refresh the site and check browser console.

Code

Live example

https://rawcdn.githack.com/mrdoob/three.js/dev/editor/index.html

Screenshots

No response

Version

r165dev

Device

Desktop

Browser

Chrome

OS

MacOS

[Mugen87]

/ping @ycw

[ycw]

Already solved by "Editor: Fixed recovery system" #28345

You can try it at https://raw.githack.com/ycw/three.js/editor-commands-defer-init/editor/index.html

Was asked to split #28345 into small PRs for reviews, I did that but there's no signals after that :D

[Mugen87]

Which of the new PRs fixes this particular issue?

Was asked to split #28345 into small PRs for reviews, I did that but there's no signals after that :D

Please keep in mind that our review time is limited and the editor related PRs of you and @linbingquan claimed a considerable amount of reviewing and testing bandwidth in the last week. We also want to review other PRs and work on our own stuff so please do not expect too much attention.

[ycw]

#28360
#28361
#28362

[Mugen87]

After testing it seems #28360 is sufficient to fix this particular issue.

[ycw]

Since the issue isn't material-related #28362 nor about SetGeometryCommand #28361, so yes, its related to #28360 only.