Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EffectComposer/Transmission: Using scene.background with a texture and having an EffectComposer breaks transmission rendering #28796

Closed
hybridherbst opened this issue Jul 3, 2024 · 3 comments · Fixed by #28806
Milestone

Comments

@hybridherbst
Copy link
Contributor

hybridherbst commented Jul 3, 2024

Description

It looks like there's a depth clear issue (?) when using a scene background together with EffectComposer when transmissive objects are rendered.

The result is that only the background is visible in transmission, not the scene content. Sometimes parts of the scene content are visible but then "disappear" (thus my assumption that this is related to some depth buffer not being cleared correctly).

Reproduction steps

  1. Go to https://jsfiddle.net/0zLhsk3u/103/
  2. Rotate the camera a bit (first frame likely works because depth buffer is empty before!)
  3. Note that the grey object is not visible in the transmission
    image.
  4. Press "F" which will switch from a background texture to a background color.
  5. Note that the dark green sphere is visible in transmission again.
    image.
  6. Press "F" again to switch to background texture again (dark green sphere disappears from transmission)
  7. Press "C to disable the EffectComposer
  8. Note that the dark green sphere is visible again

So this combination breaks:

  • Background texture + EffectComposer + Transmission

Code

See https://jsfiddle.net/0zLhsk3u/103/

Live example

https://jsfiddle.net/0zLhsk3u/103/

Version

r167dev

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 4, 2024

This is a regression since the demo works up to r164: https://jsfiddle.net/Lrvkd0s1/

It starts breaking with r165 which contains a fix for another transmission issue: #28420

Maybe the fix has a side effect that is the root cause for this issue.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 4, 2024

The PR #28434 fixed an issue in context of color spaces in r165. #28447 tried to optimized the code but introudced this regression. I'll revert the PR.

@Mugen87 Mugen87 modified the milestones: r166, r167 Jul 4, 2024
@hybridherbst
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants