-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes: RenderOutputNode name change #29163
Comments
TBH, I find the If you want to change to But right now, I don't see enough arguments to go through all these name changes. |
I'm not opposed to a change, but I'm having trouble convincing myself of the improvement. Perhaps worth noting, the closest term in WebGL would be |
Description
RenderOutputNode
converts scene-referred linear light values to display-referred code values, and then converts the code value to a color space appropriate for the display.The current name is derived from
OutputPass
, but I think we can do better.Solution
I suggest the following nomenclature changes:
RenderOutputNode
=>DisplayNode
,DisplayViewNode
, orViewNode
renderOutput
=>display
,displayView
, orview
Given that the transforms in this node are specific to a display, it seems reasonable to include
Display
in the name.A "view", I believe, can include additional post-processing. That may be appropriate if the node were to include other optional transforms at some point.
//
For clarity, this is the current nomenclature:
I recommend this nomenclature:
Alternatives
None.
Additional context
No response
The text was updated successfully, but these errors were encountered: