-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webXR button does not switch to third state when fullscreen VR is exited using the controller #29457
Comments
This is confusion with the 2nd resume button placed by the browser near the address bar and the VR fullscreen running in the background with one button saying resume and one button saying enter. There should be a standard word of all VR buttons and Oculus used resume meaning there should be a 3rd state of this button. |
Resume is the third state and it is in your 2nd screenshot. It is a third state because your browser shows 3 buttons (Enter, Resume, and Quit). The |
Ah, but 'resume' isn't a state, it's an action. The button only cares about the two states of there being an immersive session or not. It already shows the relevant action to transition between these two states. In any case, it's not possible to implement this "resume" action. And, like I mentioned, won't even make sense for PCVR or handheld AR. Even if it would be possible, I'm not sure it should be included in the |
@mrxz the enter action is described as resume when there is an existing immersive session. The button should say resume as the browser button does when there is an existing immersive session and the action that it invokes when clicked is the same as the enter action. |
You haven't addressed any of the concerns. The 'Resume' button does something that you can't do programmatically. If it would do the "same as the enter action" it would request a new immersive session when there is already an active session. As per the WebXR spec, this will give an error. Feel free to verify this behaviour yourself.
There are many different WebXR capable user agents, so it's infeasible to try and match the wording used by each one of these. The current wording seem clear enough to me, and if users want to customize it, they can easily make their own version of the button. If you feel strongly about this feature, you should try and get WebXR spec expanded so that implementing the resume action becomes possible. Until then, there's literally nothing that can be done on the Three.js side. |
@mrxz the buttons having different action names than the browser has is not normal. |
Matching the wording and behavior of the Meta Quest Browser — let alone every possible WebXR-compatible browser — is neither a goal of the 200-line @andrewhodel Please be respectful of the time and energy of others: continued argument and @-pings in a closed thread are unhelpful. I would recommend that you create a button customized to your wording needs, if you prefer a different behavior. |
Description
The webXR button does not switch states when fullscreen VR is exited using the controller.
If you click the XR button to start fullscreen, then exit fullscreen by pressing a button on the controller the button still says enter while the standard nomenclature of the Oculus browser says resume in the browser placed button near the address bar.
Reproduction steps
Code
NA
Live example
Screenshots
No response
Version
168
Device
Headset
Browser
No response
OS
No response
The text was updated successfully, but these errors were encountered: