-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPURenderer: Shadows Performances Issues #30065
Labels
Comments
I'm curious why it's testing |
Repository owner
deleted a comment from
yuvashrikarunakaran
Dec 16, 2024
Repository owner
deleted a comment from
Danilkat
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Regarding the recent work on
customCacheKey
,lights
, andshadows
, is there a way to preventrenderShadow
from callingrenderObject.needsUpdate
on every frame for every object?In a moderately sized application, this check significantly impacts performance, causing a solid 30% drop (roughly 30–40 FPS). The check seems redundant, as we override the materials for the entire scene anyway.
If needed, this issue can likely be reproduced by enabling shadows in the
webgpu_performance
example.Here’s a before/after comparison showing the impact of bypassing the cacheKey check for shadows:
With this hardcoded condition as a POC:
The scene renders correctly as I believe the cacheKey check isn't needed anyway for shadows.
/cc @sunag @Mugen87.
The text was updated successfully, but these errors were encountered: