Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SceneLoader-Import of Spotlight causes error #4191

Closed
ghost opened this issue Dec 8, 2013 · 8 comments
Closed

SceneLoader-Import of Spotlight causes error #4191

ghost opened this issue Dec 8, 2013 · 8 comments
Labels

Comments

@ghost
Copy link

ghost commented Dec 8, 2013

I am trying to import a whole scene from Blender, what fails if the (spot)lights are included. Details about the issue can be found here (stackoverflow).

Details: Ubuntu 12.04, Nvidia GeForce GT 330M, Blender 3.69, all browsers

Regards, philipp

@WestLangley
Copy link
Collaborator

See 1cb9e9c

The code should at least run if light.target is replaced with light.target.position. Of course, it still needs to be tested.

@ghost
Copy link
Author

ghost commented Dec 9, 2013

I digged a bit deeper in that and found the following:

  1. the fix suggested above works, so no errors occur any longer
  2. I created a basic scene in Blender and exported, but the positions of the lights are wrong. After some playing around I noticed that the coordinates are not flipped correctly if »flip y and z« is enabled, so the y-coordinate seems to be negative in the result (I used only Spot- and Point-lights for tests)
  3. If I rename the Camera from »Camera« to something different (in Blender 2.69), the export fails and no js file is generated
  4. all in all everything works pretty nice and its a pleasure to use!

@metal3d
Copy link

metal3d commented May 13, 2014

Just to precise that I just tested today and this bug is still here... Should I provide a pull-request ?

@mrdoob
Copy link
Owner

mrdoob commented May 14, 2014

@metal3d go for it!

@metal3d
Copy link

metal3d commented May 14, 2014

Ok, I will do both fixes:

  • change loader
  • modify Blender exporter to invert some coord + get the default Camera (I understood why sometimes the camera is not used... that's when Camera is not the selected objet when export is launched...)

I will try this tonight (it's 11:00am here in France)

Exuse my bad english, sometimes I'm typing very fast and I don't re-read what I write...

@metal3d
Copy link

metal3d commented May 15, 2014

Arrrrgh I was working on master branch... just realized that SceneLoader disapeard in "dev" branch (git log says that it's moved to examples - #4739). That means that I should do some big changes...

@mrdoob
Copy link
Owner

mrdoob commented May 16, 2014

Actually. I removed SceneLoader completely... It's way too hard to maintain :S

@mrdoob
Copy link
Owner

mrdoob commented May 16, 2014

Maybe should keep it for some releases still, but it's buggy.
We need to focus on the new file format and write new/clean exporters for Blender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants