Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Don't hardcode output to output.mp4 #2

Closed
mre opened this issue Oct 27, 2018 · 1 comment
Closed

Don't hardcode output to output.mp4 #2

mre opened this issue Oct 27, 2018 · 1 comment

Comments

@mre
Copy link
Owner

mre commented Oct 27, 2018

In #1 (comment), I mention that the output of this tool is currently hardcoded to output.mp4. See

self.output = "{}/output.mp4".format(output_dir)
.
That's bad, because a new recording will overwrite the previous one. We could fix that by adding a timestamp for the output file, for example.

Might be a nice exercise for new contributors.

@mre
Copy link
Owner Author

mre commented Oct 27, 2018

Fixed with #3

@mre mre closed this as completed Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant