Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should mock fetching the public certificate when testing primary functionality #70

Open
tejashah88 opened this issue Jan 9, 2024 · 1 comment
Open

Tests should mock fetching the public certificate when testing primary functionality #70

tejashah88 opened this issue Jan 9, 2024 · 1 comment

Comments

@tejashah88
Copy link
Contributor

I've noticed that the tests in test/index.js mostly don't mock fetching the certificate from the URL, which can lead to flaky tests. I recommend adding mocking functionality (similar to how you used nock in test/fetch-cert.js).
@mreinstein
Copy link
Owner

open to a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mreinstein @tejashah88