Remove React peer dependency #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backporting this to 2.x would be pretty important since libraries like |
|
I don't believe 2.x has a peer dependency. |
|
That was kind of my point. Since the major version bump was only done because of the added peer dependency removing the peer makes every change in 3.x eligible for 2.x, no? |
|
Ah, I see what you're saying. I would prefer to remove that breaking change in 3.x and have everyone upgrade to that version rather than backport. I think it is in everyone's best interest to have everyone on the same version rather than support multiple versions that could be duplicated in their bundles. |
|
Fair point. Could you ping me once this gets released? |
|
This is published in v3.2.0. @eps1lon ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65.
This is no longer a requirement since we do not need to require React anymore.