-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One line commit messages should not be rejected #55
Comments
Hi @johnboyes , So far, enforcing a body proved to provoke people to write more informative messages, so I didn't even think about allowing one-liners. |
Sounds good, thanks @mristin. I'd propose allowing one liners as the default (as the guidelines say they are allowed), and adding a flag to optionally disallow them? |
@johnboyes I added the feature and pushed the minor version to 2.1.0.
The action is already used in quite a few pipelines, so I left it as an optional flag (we actually want to disallow one-liners in those projects). |
No problem, @mristin, and thanks for the quick turnaround 👍 Once you have published the 2.1.0 release I'll give it a whirl 😎 |
@johnboyes the release should be up now. |
Thanks @mristin, have updated my client repo to use it and have tested it - all working well. |
One line commit messages are currently rejected with the message:
Expected at least three lines (subject, empty, body), but got: 1
Chris Beams's guidelines say that one line messages are just fine, however:
The text was updated successfully, but these errors were encountered: