Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration option to exclude paths #219

Closed
adam-26 opened this issue Mar 29, 2023 · 2 comments
Closed

Add a configuration option to exclude paths #219

adam-26 opened this issue Mar 29, 2023 · 2 comments
Labels
question Further information is requested

Comments

@adam-26
Copy link
Contributor

adam-26 commented Mar 29, 2023

Is your feature request related to a problem? Please describe.
This plugin includes the node_modules folder in the search path.
Some packages are published that include CSS imports (ie:import './some.css' ) but the .css file is not included in the package, that causes this plugin to crash.

Describe the solution you'd like
Add a configuration option excludePath(s), that accepts a string | RegEx that is then used to exclude the specified paths from reading css files.

Describe alternatives you've considered
None.

Additional context
Being able to exclude paths would likely improve plugin performance.

@mrmckeb
Copy link
Owner

mrmckeb commented Apr 10, 2023

Hi @adam-26, the "crash" issue should have been solved by #218 (thank you). Do you think that's enough for now?

The plugin itself only tries to read CSS from node_modules if it's imported (or imported by an import).

@mrmckeb mrmckeb added the question Further information is requested label Apr 10, 2023
@adam-26
Copy link
Contributor Author

adam-26 commented Apr 10, 2023

Hi @mrmckeb, thanks for fixing and merging #218 it's much appreciated. I agree that that's enough for now, thanks again.

@adam-26 adam-26 closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants