Skip to content
This repository has been archived by the owner on Apr 8, 2023. It is now read-only.

Adopt formatOnSave changes #26

Closed
jrieken opened this issue Oct 18, 2016 · 2 comments
Closed

Adopt formatOnSave changes #26

jrieken opened this issue Oct 18, 2016 · 2 comments
Assignees
@mrmlnc

Comments

@jrieken
Copy link

jrieken commented Oct 18, 2016

Related to mrmlnc/vscode-stylefmt#28, I'd recommend to rely on the new format on save-feature. It will reduce the risk of endless event-write-event-write loops and be a neater integration
@ryanbowden
Copy link
Contributor

Are you sure it does not already support this? As I have my SCSS files being watched by a gulp task and it only sees one write when I use this.

@jrieken jrieken mentioned this issue Oct 18, 2016
Closed
10 tasks
@jrieken
Copy link
Author

jrieken commented Oct 18, 2016

Actually, true. Didn't see that is already is onWillSaveTextDocument. Thanks for catching this.

@jrieken jrieken closed this as completed Oct 18, 2016
@mrmlnc mrmlnc self-assigned this Oct 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrmlnc mrmlnc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jrieken @ryanbowden @mrmlnc