Skip to content

Commit 57c4ac1

Browse files
committed
Check package to test in benchmark in every loop
Check which package is being tested in case of benchmark suite, but keeping all these test packages in the same step.
1 parent 107363b commit 57c4ac1

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

.buildkite/pipeline.trigger.integration.tests.sh

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,8 @@ CHECK_PACKAGES_TESTS=(
3636
test-check-packages-benchmarks
3737
)
3838
for test in ${CHECK_PACKAGES_TESTS[@]}; do
39-
options=""
40-
if [ "${test}" == "test-check-packages-benchmarks" ]; then
41-
package_name=$(basename ${package})
42-
options="-p ${package_name}"
43-
fi
4439
echo " - label: \":go: Running integration test: ${test}\""
45-
echo " command: ./.buildkite/scripts/integration_tests.sh -t ${test} ${options}"
40+
echo " command: ./.buildkite/scripts/integration_tests.sh -t ${test}"
4641
echo " agents:"
4742
echo " provider: \"gcp\""
4843
echo " artifact_paths:"

scripts/test-check-packages.sh

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,21 +69,23 @@ for d in test/packages/${PACKAGE_TEST_TYPE:-other}/${PACKAGE_UNDER_TEST:-*}/; do
6969
elastic-package install -v
7070

7171
if [ "${PACKAGE_TEST_TYPE:-other}" == "benchmarks" ]; then
72-
if [ "${PACKAGE_UNDER_TEST:-*}" == "pipeline_benchmark" ]; then
72+
# It is not used PACKAGE_UNDER_TEST, so all benchmark packages are run in the same loop
73+
package_to_test=$(basename ${d})
74+
if [ "${package_to_test}" == "pipeline_benchmark" ]; then
7375
rm -rf "${OLDPWD}/build/benchmark-results"
7476
elastic-package benchmark pipeline -v --report-format xUnit --report-output file --fail-on-missing
75-
77+
7678
rm -rf "${OLDPWD}/build/benchmark-results-old"
7779
mv "${OLDPWD}/build/benchmark-results" "${OLDPWD}/build/benchmark-results-old"
78-
80+
7981
elastic-package benchmark pipeline -v --report-format json --report-output file --fail-on-missing
80-
82+
8183
elastic-package report --fail-on-missing benchmark \
8284
--new ${OLDPWD}/build/benchmark-results \
8385
--old ${OLDPWD}/build/benchmark-results-old \
8486
--threshold 1 --report-output-path="${OLDPWD}/build/benchreport"
8587
fi
86-
if [ "${PACKAGE_UNDER_TEST:-*}" == "system_benchmark" ]; then
88+
if [ "${package_to_test}" == "system_benchmark" ]; then
8789
elastic-package benchmark system --benchmark logs-benchmark -v --defer-cleanup 1s
8890
fi
8991
else

0 commit comments

Comments
 (0)