Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hermes location detection for Android example app #223

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

perunt
Copy link
Contributor

@perunt perunt commented Oct 14, 2024

This PR addresses the build failure occurring during the creation of the release bundle for Android. The error was caused by the inability to determine the Hermes location.

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 3:59pm

@perunt perunt marked this pull request as ready for review October 15, 2024 09:31
@mrousavy mrousavy merged commit f2e86d3 into mrousavy:main Oct 16, 2024
4 checks passed
@mrousavy
Copy link
Owner

LGTM thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants