fix: Perform safer checks for toContain(..) in example, and add NitroModules.hasNativeState(value)
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
mrousavy
changed the title
toContain(..) in exampletoContain(..) in example, and add NitroModules.hasNativeState(value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new API to
NitroModules:NitroModules.hasNativeState(value).With this API, we guard the
toString()call of a HybridObject in release builds because we relied on an error being thrown, which turns into an assert (crash) in release.To avoid relying on an error being thrown, we instead now somewhat safely check if we can stringify an object by checking if it has
toString()or inherits from it - and then we check if it has NativeState. It is a fair assumption thattoString()from prototype only works if we have NativeState, at least in the Nitro world.