fix: read local files on Android for 'file:///...'

[davidgaag]

When loading the model with a file:/// URI on Android, a network request was attempted, causing Android to throw the error Expected URL scheme 'http' or 'https' but was 'file'.

This pull request adds a check for the URI scheme, and if it's file, the app will now load from the local file system.

I also included a check for the .tflite extension when loading the file to ensure other files aren't read/misused.

Please note that I tried to run the Jest tests, but was stopped by an error in a react-native file/dependency. I tried to figure out how to exclude that file and run the tests anyways, but I had no luck.

(This is my first PR/open source contribution, so I hope I did this right 😅)

fixes #80 fixes #63

[davidgaag]

Drafted because of an out of memory error I discovered with this approach. Will re-open if/when I discover a fix.

[phuvinhng]

How can you fix on Android? iOS working ok

[phuvinhng]

Hey @davidgaag, I tried your updated code, and surprisingly it worked, you can check some more reasonable cases if needed, thanks

[mrousavy]

thanks for your PR! We'll test this internally

[lucksp]

Should the loading-models section of README be updated to show the difference between File & URL? I think the current URL scheme is documented incorrectly. The reason is, if you don't use {url: string} the error says:

[Error: TFLite: Invalid source passed! Source should be either a React Native require(..) or a { url: string } object!]

The example should be:

// Asset from React Native Bundle
loadTensorflowModel(require('assets/my-model.tflite'))
// File on the local filesystem
loadTensorflowModel('file:///var/mobile/.../my-model.tflite')
// Remote URL
loadTensorflowModel({ url: 'https://tfhub.dev/google/lite-model/object_detection_v1.tflite' })

[Ajith-JSN]

Hi @mrousavy , could you please let us know when this PR might be merged?

[mrousavy]

@Ajith-JSN did you test this PR? Does it work for you?

[Ajith-JSN]

@Ajith-JSN did you test this PR? Does it work for you?

Yes, I have tested it, and it works fine

[mrousavy]

Then LGTM!

[mrousavy]

thanks for your PR! :)

[xinjietang]

Hi everyone, has this commit been included in the 1.4.0 release?

[lucksp]

Has this been tested on iOS also? I am seeing the same issue there when trying to load a file:// URI:

Error: TFLite: Invalid source passed! Source should be either a React Native require(..) or a { url: string } object!

[xinjietang]

Has this been tested on iOS also? I am seeing the same issue there when trying to load a file:// URI:

Error: TFLite: Invalid source passed! Source should be either a React Native require(..) or a { url: string } object!

I have created a pull request at #102. Please try out if it fixed the issue.