Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return success state for set and recrypt calls #583

Closed
antondalgren opened this issue Sep 26, 2023 · 1 comment · Fixed by #706 · May be fixed by #584
Closed

Return success state for set and recrypt calls #583

antondalgren opened this issue Sep 26, 2023 · 1 comment · Fixed by #706 · May be fixed by #584

Comments

@antondalgren
Copy link

The underlying MMKV library returns booleans on these calls wether the set or recrypt was made successfully or not. It would be nice if these boolean values were to be exposed in the JS world as the application developer may want to do different actions based on the outcome of these method calls.

https://github.com/Tencent/MMKV/blob/272e5aa1fb57b4ee8cc0ff37e70b7885d99832a7/Core/MMKV_IO.cpp#L1101

https://github.com/Tencent/MMKV/blob/272e5aa1fb57b4ee8cc0ff37e70b7885d99832a7/Core/MMKV_IO.cpp#L557
@antondalgren antondalgren mentioned this issue Sep 26, 2023
Open
@mrousavy mrousavy mentioned this issue Jul 22, 2024
Merged
@mrousavy
Copy link
Owner

Implemented in #706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@antondalgren @mrousavy