-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle both scope and resource permission types #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Would you be able to update one of the existing test cases for this resource to include the new scopes
attribute?
@mrparkers |
@mrparkers Wow! This would be really helpful. Can we get this merged? It looks like the tests have been completed. |
Thanks for adding the tests, @Amad27! I pulled this down locally and tested the changes you made to |
@mrparkers I just retested it locally and was able to get it to apply and destroy without errors after running the |
Hmm, I must have had something weird going on with my local setup, because I'm not running into those errors anymore. I probably just messed something up locally. |
… scope and resource permission types (keycloak#220)
… scope and resource permission types (keycloak#220)
This PR allows for handling all types of permissions - resources as well as scopes