Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for deployed js policies #275

Merged
merged 5 commits into from
May 18, 2020
Merged

Conversation

alevit33
Copy link
Contributor

With this little change, it's possible to create js policies from already deployed policies. The field "code" of the resource "keycloak_openid_client_js_policy" can now be 2 things:

  • javascript code, so that a brand new policy is created
  • a javascript file already deployed, so that a new policy is created starting from this file.
    This is recommended since in the last version of Keycloak uploading js code is disabled by default, but it's still possible for backwards compatibility.

Tested with Keycloak v9.0.3 and Terraform v0.12.24

@alevit33
Copy link
Contributor Author

Also added support for User Managed Access at realm level

@mrparkers
Copy link
Contributor

Awesome, can you update the docs for the keycloak_openid_client_js_policy resource to explain this change, and run make fmt on your branch please?

@alevit33
Copy link
Contributor Author

alevit33 commented May 8, 2020

Ok, make fmt done.
The docs for keycloak_openid_client_js_policy doesn't exist yet, as well as the docs for all the client policies. They should be created, but honestly I'm not sure to know all the fields... For now, I've added a note in the example file example/client_authorization_policys

Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mrparkers mrparkers merged commit 362b465 into keycloak:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants