Improve provider connection: allow ommited "/auth" and improve login-error-messages #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmarx
force-pushed
the
improved-provider-connection
branch
from
c56cf1e
to
93a4e39
Compare
mrparkers
reviewed
Jul 6, 2020
If the login to keycloak fails with a non-JSON-response (e.g. due to a reverse-proxy returning 502 or 403 etc.), the error-message is rather arcane. By checking the status-code this commit turns "Error: invalid character '<' looking for beginning of value" into "Error: error sending POST request to http:///localhost:8080/auth/realms/master/protocol/openid-connect/token: 403 Forbidden"
elmarx
force-pushed
the
improved-provider-connection
branch
from
93a4e39
to
ac015ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Strictly speaking this PR addresses two distinct issues, but both are rather small.
First, the provider previously did not check the status-code of the initial login, so if some reverse-proxy returns an error and a non-JSON-error-message, the error-message is just about a parsing failure. By explicitly checking the HTTP-status-code, the provider can show more precise error messages.
The second commit enables to use keycloak at another web-context then "/auth" (e.g. to leave out "/auth" completely).
Maybe it would be nicer to just use the setting
baseUrland require users to include "/auth" if necessary, but that would introduce a breaking change, so I opted to add an additional optional setting to override the "/auth" part.