Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register required action if not reqistered #385

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Register required action if not reqistered #385

merged 2 commits into from
Sep 18, 2020

Conversation

klausenbusk
Copy link
Contributor

Fix #354

@klausenbusk

This comment has been minimized.

@klausenbusk
Copy link
Contributor Author

klausenbusk commented Sep 13, 2020

I'm not sure the failures is related to the changes?

I just rebased with the circleci test timeout from master (000b248) and now CI is green.

@mrparkers
Copy link
Contributor

this looks good, just a couple of thoughts:

  • could you add the example action you're using to one of the existing test cases to verify that this will work going forward
  • in terms of the lifecycle of a newly registered required action, do you think it should be "unregistered" on delete? just want to hear your thoughts on this.

@klausenbusk
Copy link
Contributor Author

could you add the example action you're using to one of the existing test cases to verify that this will work going forward

Sure, will do.

in terms of the lifecycle of a newly registered required action, do you think it should be "unregistered" on delete? just want to hear your thoughts on this.

You can't "unregister" a required action, you can only delete it (at which point you would need to register it again).

Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding that test, LGTM 👍

@mrparkers mrparkers merged commit a7aa1e8 into keycloak:master Sep 18, 2020
hcl31415 pushed a commit to hcl31415/terraform-provider-keycloak that referenced this pull request Oct 12, 2020
hcl31415 pushed a commit to hcl31415/terraform-provider-keycloak that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support registering a new required action
2 participants