Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import of service account realm role mapping #441

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Fix import of service account realm role mapping #441

merged 2 commits into from
Dec 9, 2020

Conversation

toddkazakov
Copy link
Contributor

No description provided.

@toddkazakov
Copy link
Contributor Author

@mrparkers can you please review the PR?

@mrparkers
Copy link
Contributor

hey @toddkazakov, there was actually more problems with this import implementation besides your fix. I went ahead and fixed that and added a test as well. Let me know what you think and we can get this merged.

@toddkazakov
Copy link
Contributor Author

Looks good to me @mrparkers, thank you very much

@mrparkers mrparkers merged commit 8446cad into keycloak:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toddkazakov @mrparkers