Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saml principal #508

Merged
merged 5 commits into from
Apr 9, 2021
Merged

Conversation

alex-hempel
Copy link
Contributor

Hi Michael,

please review this pull request.

It adds support for the following SAML attributes:

principalType
principalAttribute
guiOrder
syncMode

This addresses some requirements we have, but it also partially addresses some existing issues:

#433
#390

@alex-hempel
Copy link
Contributor Author

I am unsure about this test failure. Do you have any advice?

Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test failure just looks to be a random 500 in the middle of tests. sometimes keycloak can get overwhelmed with all of the tests we do 😄

I'll merge this as soon as it passes (just kicked it off again). thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants