fix: use consistent config / extra_config across identity providers #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrutsaert
approved these changes
Apr 30, 2021
| @@ -89,12 +99,72 @@ func resourceKeycloakIdentityProvider() *schema.Resource { | |||
| Default: "", | |||
| Description: "Alias of authentication flow, which is triggered after each login with this identity provider. Useful if you want additional verification of each user authenticated with this identity provider (for example OTP). Leave this empty if you don't want any additional authenticators to be triggered after login with this identity provider. Also note, that authenticator implementations must assume that user is already set in ClientSession as identity provider already set it.", | |||
| }, | |||
| // all schema values below this point will be configuration values that are shared among all identity providers | |||
| "extra_config": { | |||
There was a problem hiding this comment.
So basically extra config(and gui_order and sync_mode) was moved to the generic identity provider, 👍
| Detail: fmt.Sprintf(`extra_config key "%s" is not allowed, as it conflicts with a top-level schema attribute`, jsonKey), | ||
| AttributePath: append(path, cty.IndexStep{ | ||
| Key: cty.StringVal(jsonKey), | ||
| }), |
There was a problem hiding this comment.
This is great, This will help people to understand what is going on, even if they did not read the release notes
|
|
||
| extra_config = { | ||
| "syncMode" = "IMPORT" | ||
| } |
There was a problem hiding this comment.
I would still give an example of extra config:
extra_config = {
"myCustomConfigKey" = "myValue"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gui_orderandsync_modeare now supported by all identity providers as top-level attributesextra_configattribute now fails validation if a key is used that conflicts with the existing identity provider config JSON modelThis doesn't really "fix" the root problem, but the extra validation here will prevent potentially bad configuration for an identity provider from reaching a Keycloak instance.
Fixes #520
cc @tomrutsaert @alex-hempel