feat: Add keycloak_groups_permissions for admin_fine_grained_authz #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoeggi
changed the title
|
This looks great, thanks for the PR! The only thing I'd like to be changed is to rename this resource from You may have borrowed this naming convention from Other than this change, everything else LGTM. |
|
Yes you are right, i did borrow lot's of existing code :) I did a full rename from groups to group on all filenames/resources. |
mrparkers
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a to add support for fine grained permissions on groups, it's somewhat similar to #409
I needed this internally so it is still missing documentation and tests. I marked this PR as WIP to ask if you are interested in this and if yes i will finish up with documentation and add the test cases.Edit: I already added some documentation and a basic test case. Let me know if you would like anything more.