Enable custom client_authenticator_type #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrparkers
suggested changes
Dec 7, 2021
There was a problem hiding this comment.
Hey @oysteinhauan, sorry for the delay on this. I just had one comment before this can get merged. Thanks!
…/oysteinhauan/terraform-provider-keycloak into specify-client-autheticator-type
|
@mrparkers is this ready to be merged now? :) |
mrparkers
approved these changes
Jan 20, 2022
mrparkers
approved these changes
Jan 20, 2022
|
Not sure why that approval posted twice 😄 |
|
Wonderful! Thanks! Looking forward to the release - we've been using a local version of the provider and it seems to work great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396
Kept the hardcoded clientAuthenticatorType for backwards compatibility, while enabling it to be specified with the possible values ["client-secret", "client-secret-jwt", "client-x509", "client-jwt"].