feat: add keycloak_realm_user_profile resource
#658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To have the tests running successfully in CI, the |
mrparkers
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Hi @maximepiton, thanks for getting this PR submitted. I'm sorry it took so long to review. I just got around to testing this out today and everything looks good. I have a few minor nitpicks to the code but I'm just going to take care of those in a follow-up PR for you.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
This PR adds a User Profile resource to the provider (as my team need it).
As the User Profile is still a preview feature, and is managed through a specific endpoint, I thought that it was better to set it as a separate resource and not set user profile settings in the keycloak_realm resource directly.
Some tests unrelated to this feature (keystores, federation) fail when I run them locally, but I think it's a flakiness issue..?
Let me know what you think!