Address runtime errors when importing authz resources #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation and API expects the resource identifier to be made up of 3 parts, but we're accessing the 4th element which will always be undefined. This results in a imports for these resource types failing with a cryptic error: "error: code = Canceled desc = context canceled"
In CI/CD environment, we can use helper modules to automatically install specific versions of GoLang and other system dependencies. For local development, not all devs/contributors may have the right GoLang or OS deps setup already. So we offer one using docker-compose. This simplifies the (local) build process to this; all you need is docker + compose. ```bash $ docker-compose run --rm app bash $ make build ```
|
GitHub says I need maintainer approval to launch the checks for this PR. @mrparkers can I get approval to run workflows? |
|
Sorry for taking so long to get around to this @naushadh. PRs from first-time contributors are gated to avoid potential abuse, such as using the GitHub Actions runner to mine cryptocurrency lol. I've approved this PR to run so we should be able to make some progress on this. Thanks for submitting this PR! |
As requested by maintainer: mrparkers@ad00313#r1026743975
mrparkers
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #762