Compute extra_config for data sources
#885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kherock
changed the title
extra_config for keycloak_openid_client data sourceextra_config for data sources
kherock
force-pushed
the
compute-openid-client-extra-config
branch
from
27033ab
to
aacf3d2
Compare
kherock
force-pushed
the
compute-openid-client-extra-config
branch
from
aacf3d2
to
39ba25b
Compare
kherock
force-pushed
the
compute-openid-client-extra-config
branch
from
39ba25b
to
2f8cd93
Compare
mrparkers
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884
The build of the first commit shows the expected bug that was originally hidden due to a bad test definition:
To fix, I modified the data source routines to set
extra_configto the value directly obtained from the client attributes.