Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish count of zeros #4

Open
gjahansen2 opened this issue Jun 10, 2023 · 3 comments
Open

Fish count of zeros #4

gjahansen2 opened this issue Jun 10, 2023 · 3 comments

Comments

@gjahansen2
Copy link

gjahansen2 commented Jun 10, 2023

Note that there are fish counts of zero in older data (all with survey status = "MIGRA") and dplyr::uncount() drops those rows. Question for Corey - are those mistakes in an import (and if so should be 1 or possibly another number?) or are they in there to indicate zero catch?

@mrverhoeven
Copy link
Owner

Currently the SURVEY_STATUS field is in the garbage bin. Consider elevating to preserve if useful to future merges/work/anything. Otherwise, if it is only useful as a diagnostic to fix a contributed file, it can stay in the garbage bin (those things aren't dropped, just sorta tagged as "not needed to us").

@mrverhoeven
Copy link
Owner

From a GH slack message: "FYI the issue I raised where TOTAL_CATCH=0 in raw data is not an issue -at least, not the kind I thought it was. In fact, these are duplicates, so we do NOT need to add in the data as I was doing. They can just be dropped because all the fish counted in the CPUE data have lengths in the raw data. At least for the GN surveys."

@mrverhoeven
Copy link
Owner

We need to look at the total count column in the individual fish file to verify whether or not there is a need for an uncount of those indiv fish data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants