-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Remapping is ignored on both ROS1 and ROS2 #1150
Comments
I met the same problem with python launch file. Ros extension in VSCODE ignore the remappings in launch.py when start debuging If run command in terminal, it has no problem |
@xoofee what do you mean Python launch file? As in you have a .launch file which includes a python node? Yes if run from the terminal, this remapping problem does not occur. Would be nice to get it to work in VS code ROS extension |
yes, I mean xxx.launch.py file in python format, this is an example `from launch import LaunchDescription def generate_launch_description(): However, if I do not use the tilde ~/ in my topic name, just 'input', the VS code ROS extension has no problem for the remap. |
@xoofee thanks for your reply. Where do I find this .launch.py file, is it generated for any .launch file that I have or did you specifically create it yourself for use with VSCode ROS extension? |
Just to confirm -This looks like it repros on both ROS1 and ROS2? |
(Please add appropriate labels)
<Version of the plugin>
v0.8.4
<Copy the Version information from the
Help | About
menu>Version: 1.82.2
Commit: abd2f3db4bdb28f9e95536dfa84d8479f1eb312d
Date: 2023-09-14T05:51:20.981Z
Electron: 25.8.1
ElectronBuildId: 23779380
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Linux x64 5.4.0-150-generic snap
what is the bug
<current behavior>
I get the following error from VS code debugger: "Error from roslaunch: WARN: unrecognized 'remap' tag in tag"
Repro steps
<how to reproduce the bug. Please attach sample files or github repo if appropriate.>
Launched in VS code: master_rag_simulation.launch:
`
`
Launched from terminal: master_rag_sim_terminal.launch:
`
`
When I launch this file, particularly the "multi_karto_gtsam_posfilter.launch" file, I get the following error from VS code:
"Error from roslaunch: WARN: unrecognized 'remap' tag in tag"
This is what my multi_karto_gtsam_posfilter.launch file looks like:
`
`
expected behavior
<what you would expect to happen>
I expect to see no error or warning, and the debugger steps through breakpoints in the C++ nodes.
additional context
<any additional information would be helpful for a better understanding>
I see that this error originates from tools/roslaunch/src/roslaunch/xmlloader.py, line 583. When I run the launch files from my terminal, they work correctly with no errors.
The text was updated successfully, but these errors were encountered: