Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not mapped issue #17

Closed
saigkill opened this issue Apr 9, 2022 · 1 comment
Closed

Not mapped issue #17

saigkill opened this issue Apr 9, 2022 · 1 comment
Labels
enhancement-S New feature request. Tshirt size: S released Issue is resolved in a current release
Milestone

Comments

@saigkill
Copy link

saigkill commented Apr 9, 2022

I have the following case: I have a BaseEntity where all other Entity derive from. Inside that i have some standard things defined, like ID, Created and Modified. Currently i solved that case by adding a custom atribute "NotMapped" to the BaseEntity class. After gerneration was the BaseEntity in DBSet and modelBuilder from the context. Can this be fixed?

@msawczyn msawczyn added the investigating Looking into this label Jun 27, 2022
@msawczyn
Copy link
Owner

msawczyn commented Jul 5, 2022

This is one that I've had on my plate for some time now.

I've added a "Persistent" property (defaults to true) to the class. Setting it to "false" will, after validating that it's allowed to become a transient class, cause code generation to do the things you're looking for.

Paying attention to the attributes becomes a slippery slope, since there's an uncountable number of possibilities, so supporting this with its own property helps limit that and allows the modeler to provide some assistance to folks who might try adding a transient class in the middle of an inheritance hierarchy (the tool prevents that since it causes all sorts of chaos).

Thanks for the report! It'll be in 4.2.

@msawczyn msawczyn added this to the 4.2 milestone Jul 5, 2022
@msawczyn msawczyn added enhancement-S New feature request. Tshirt size: S pending release Issue is resolved in the current codebase, will be published with the next release and removed investigating Looking into this labels Jul 5, 2022
@msawczyn msawczyn closed this as completed Jul 5, 2022
@msawczyn msawczyn added released Issue is resolved in a current release and removed pending release Issue is resolved in the current codebase, will be published with the next release labels Aug 13, 2022
@msawczyn msawczyn reopened this Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement-S New feature request. Tshirt size: S released Issue is resolved in a current release
Projects
None yet
Development

No branches or pull requests

2 participants