Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty part will hang the process #23

Open
ruur opened this issue Sep 23, 2021 · 3 comments
Open

Empty part will hang the process #23

ruur opened this issue Sep 23, 2021 · 3 comments

Comments

@ruur
Copy link

ruur commented Sep 23, 2021

If the multipart data like this:

POST /member.php?mod=register&inajax=1 HTTP/1.1
Host: domainExample
Accept: text/html, application/xhtml+xml, */*
Connection: Keep-Alive
Content-Length: 522
Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryzca7IDMnT6QwqBp7
Referer: http://domainExample/member.php?mod=register
User-Agent: Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)

------WebKitFormBoundaryzca7IDMnT6QwqBp7
Content-Disposition: form-data; name="regsubmit"

yes
------WebKitFormBoundaryzca7IDMnT6QwqBp7
------WebKitFormBoundaryzca7IDMnT6QwqBp7
Content-Disposition: form-data; name="referer"

http://domainExample/./
------WebKitFormBoundaryzca7IDMnT6QwqBp7
Content-Disposition: form-data; name="activationauth"


------WebKitFormBoundaryzca7IDMnT6QwqBp7
Content-Disposition: form-data; name="seccodemodid"


member::register
------WebKitFormBoundaryzca7IDMnT6QwqBp7--

The second part is empty,this will make the self._parts number is less then the number of processing this._part.on('end', function() {} emit. This will cause the process to hang.

@ruur ruur changed the title Empty part will make process hang. Empty part will hang the process Sep 23, 2021
@kibertoad
Copy link

This was fixed in https://github.com/fastify/busboy

@ruur ruur closed this as completed Dec 6, 2021
@mscdex mscdex reopened this Dec 6, 2021
@ruur ruur closed this as completed Dec 6, 2021
@mscdex
Copy link
Owner

mscdex commented Dec 6, 2021

@ruur Are you closing this because the issue was created in error? Otherwise it should stay open if it's an issue that exists in the master branch.

@ruur ruur reopened this Dec 8, 2021
@ruur
Copy link
Author

ruur commented Dec 8, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants