Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE_ENV log or readme.md update #101

Open
ChrisHurt opened this issue Jun 6, 2023 · 1 comment
Open

NODE_ENV log or readme.md update #101

ChrisHurt opened this issue Jun 6, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ChrisHurt
Copy link

add-pr-comment/src/main.ts

Lines 151 to 153 in 7c08905

if (process.env['NODE_ENV'] !== 'test') {
run()
}

Since NODE_ENV is a reserved environment variable in this action, this should be mentioned in the readme or in a new log.

@mshick
Copy link
Owner

mshick commented Aug 3, 2023

Excellent point. I think it might make more sense for me to use a more specific env var, to avoid any collisions. I'll get this sorted out soon. Thanks for suggesting!

@mshick mshick added the enhancement New feature or request label Aug 3, 2023
@mshick mshick self-assigned this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants